Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
local exec healthchecks #703
Final fix for #660
healthchecks, with fixes for the prometheus and pushgateway added to the local:exec runner.
I tried to lay this out so it would be less repetitive to add more checks if needed in the future.
First time running (so they all need to be fixed):
Second time running, now that they have all started:
Additionally, the process context is canceled and the processes all are killed as expected when the daemon closes.
nonsense left a comment
Overall LGTM, but I think we should consider metrics functionality as
Also if we start having problems with Prometheus (not that I think this will happen), I don't think this should have any effect on the actual runs of testplans - we should just be losing the measurements.