Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional IP selection handler #19

Closed
UmanShahzad opened this issue Oct 30, 2020 · 1 comment
Closed

Add optional IP selection handler #19

UmanShahzad opened this issue Oct 30, 2020 · 1 comment

Comments

@UmanShahzad
Copy link
Contributor

Add an optional IP selection handler to the SDK client initialization step which accepts the request context and expects returning an IP.

Add a default handler for this which looks at the X-Forwarded-For header and falls back to the source IP.

The resulting IP is the IP for which details are fetched.

@UmanShahzad
Copy link
Contributor Author

Closing as this actually only applies to middleware SDKs (e.g. Django/Rails/Express/etc), not language SDKs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant