Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do we need to maintain a submodule link to http-parser? #31

Closed
acron0 opened this issue Oct 3, 2014 · 1 comment
Closed

Do we need to maintain a submodule link to http-parser? #31

acron0 opened this issue Oct 3, 2014 · 1 comment

Comments

@acron0
Copy link
Contributor

acron0 commented Oct 3, 2014

I ask because of integration with another 3rd part library. http_parser_merged.h is maintained entitrely separately now, so why do we keep this submodule?
@ipkn
Copy link
Owner

ipkn commented Oct 5, 2014

We can remove it and just adding a note to README would be enough indicating that we are using http_parser.

@acron0 acron0 closed this as completed Nov 3, 2014
@depikaraj depikaraj mentioned this issue Feb 20, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ipkn @acron0