feat!: Node#Length() now has an error return #532
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: #531 ADL and other Node implementations that need to perform non-trivial work in calculating their Length(), such as by loading multiple child blocks, may encounter errors which should not be silently ignored.
|
Having to check an error every time you want to check an object's length is going to be a pretty painful change. I'd prefer to move that up to the constructor / otherwise have the error surface through existing error channels if possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I wanted to see how difficult this would be; although the difficulty here doesn't account for the difficulty everywhere else that's going to be hit by such a change).
Closes: #531
ADL and other Node implementations that need to perform non-trivial work in calculating their Length(), such as by loading multiple child blocks, may encounter errors which should not be silently ignored.