Binary resolver #90
Binary resolver #90
Conversation
src/index.js
Outdated
| @@ -23,6 +23,7 @@ const ipldEthStateTrie = require('ipld-eth-star').ethStateTrie | |||
| const ipldEthStorageTrie = require('ipld-eth-star').ethStorageTrie | |||
| const ipldEthTx = require('ipld-eth-star').ethTx | |||
| const ipldEthTxTrie = require('ipld-eth-star').ethTxTrie | |||
| const ipldBin = require('./ipldBin') | |||
There was a problem hiding this comment.
@kumavis mind moving this resolver to here https://github.com/ipld/js-ipld-raw ?
src/ipldBin.js
Outdated
| // binary resolver | ||
| module.exports = { | ||
| resolver: { | ||
| multicodec: 'base2', |
There was a problem hiding this comment.
I remember that discussed this in great length and the reasons why raw is different from base2. If I remember correctly, you pointed out that base2 is actually incorrect .
I'm not finding the issue where that discussion happened (I think it was in IRC, our bad for not logging it).
All of that said, let's use the codec raw here just to avoid any future confusion https://github.com/multiformats/multicodec/blob/master/table.csv#L3
There was a problem hiding this comment.
Base2 codec is literal stream of ASCI: 010100111010110.
There was a problem hiding this comment.
@Kubuxu does base2 have a code yet? in the multiformat table it has the same value as bin
|
ping @kumavis |
|
wubbalubbadubdub ok I'll get back on this horse soon |
|
@kumavis you need mr meeseeks |
|
@kumavis did something change in ipld-ethereum account? See: https://travis-ci.org/ipld/js-ipld-resolver/jobs/284172920#L2356-L2373 |
|
Not sure about the CI test failures. Some CI passed, tests pass locally for me. |
|
Thanks~ |
currently set to
base2but per discussion this might change