This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
fix: create buffers from decoded multihash digests #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`multihash.decode` returns Uint8Arrays which we set as `prevHash` but bitcoin-lib requires these to be node Buffers.
|
N.b. browser tests are failing due to babel/babel#11914 |
Codecov Report
@@ Coverage Diff @@
## master #287 +/- ##
==========================================
- Coverage 88.31% 88.23% -0.08%
==========================================
Files 3 3
Lines 154 153 -1
==========================================
- Hits 136 135 -1
Misses 18 18
Continue to review full report at Codecov.
|
vmx
approved these changes
Aug 5, 2020
64 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multihash.decodereturns Uint8Arrays which we set asprevHashbut bitcoin-lib requires these to be node Buffers.