Corner resizing doesn't scale the draw buffer correctly in WebGL

[olilarkin]

[AlexHarker]

This might be the same as the other resizing problem. We can test once I've got the fix in.

[AlexHarker]

I can't recreate this with iPlugEffect (I think I've got the build settings right). Is it bitmap related?

[olilarkin]

did you change it to use IGRAPHICS_NANOVG in IPlugEffect-web.mk ?

diff --git a/Examples/IPlugEffect/config/IPlugEffect-web.mk b/Examples/IPlugEffect/config/IPlugEffect-web.mk
index 44912e1111..828d0ae75b 100644
--- a/Examples/IPlugEffect/config/IPlugEffect-web.mk
+++ b/Examples/IPlugEffect/config/IPlugEffect-web.mk
@@ -6,13 +6,13 @@ WAM_SRC += $(IPLUG_EXTRAS_PATH)/MidiSynth.cpp

 # WAM_CFLAGS +=

-WEB_CFLAGS += -DIGRAPHICS_CANVAS
-#WEB_CFLAGS += -DIGRAPHICS_NANOVG -DIGRAPHICS_GL -DIGRAPHICS_GLES2
+#WEB_CFLAGS += -DIGRAPHICS_CANVAS
+WEB_CFLAGS += -DIGRAPHICS_NANOVG -DIGRAPHICS_GL -DIGRAPHICS_GLES2

 WAM_LDFLAGS += -s EXPORT_NAME="'AudioWorkletGlobalScope.WAM.IPlugEffect'" -O2 -s ASSERTIONS=0

-WEB_LDFLAGS += -O2 -s ASSERTIONS=0
+WEB_LDFLAGS += -O2 -s ASSERTIONS=0

 #if you want to use NANOVG/WebGL, you must link with -s USE_GLFW=3 -s USE_WEBGL2=0 -s FULL_ES3=1

-#WEB_LDFLAGS += -s USE_GLFW=3 -s USE_WEBGL2=0 -s FULL_ES3=1
\ No newline at end of file
+WEB_LDFLAGS += -s USE_GLFW=3 -s USE_WEBGL2=0 -s FULL_ES3=1

[AlexHarker]

Yes.

[olilarkin]

this is what i get, which is wrong...

[AlexHarker]

weird - I don't see any text on my builds. I will try to double check I am building correctly. Any quick way to check for nanovg?

[olilarkin]

check javascript console for "IGraphics NanoVG @ 60 FPS"

[AlexHarker]

I get this, but it works correctly - definitely using NanoVG. I'm on the master with no edits, other than the config file.

[olilarkin]

on retina screen?

[AlexHarker]

Yep.

[olilarkin]

hmmm. those errors are normal

[AlexHarker]

OK. This might be chrome version or OS specific then perhaps?

[AlexHarker]

OK - I realised I was testing the wrong mode. I have now pushed the scaling fix to master which includes some other adjustments for safety of transforms etc. Be good for you to test it at your end, but I'm confident that this should now be correct.

[AlexHarker]

fixed in 899fb26

[olilarkin]

confirmed working