Skip to content

Commit

Permalink
intf: Add missing function declarations
Browse files Browse the repository at this point in the history
ipmi_intf.h was missing a couple of declarations for the functions
used by fru, sdr and hpmfwupg modules. Add those declarations
to ipmi_intf.h and remove local declarations.

This fixes a couple of compilation warnings.

Signed-off-by: Alexander Amelkin <alexander@amelkin.msk.ru>
  • Loading branch information
AlexanderAmelkin committed Aug 29, 2019
1 parent 9006f2b commit 1724b03
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 14 deletions.
3 changes: 3 additions & 0 deletions include/ipmitool/ipmi_intf.h
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,9 @@ struct ipmi_intf {
void (*set_max_response_data_size)(struct ipmi_intf * intf, uint16_t size);
};

uint16_t ipmi_intf_get_max_request_data_size(struct ipmi_intf *intf);
uint16_t ipmi_intf_get_max_response_data_size(struct ipmi_intf *intf);

struct ipmi_intf * ipmi_intf_load(char * name);
void ipmi_intf_print(struct ipmi_intf_support * intflist);

Expand Down
6 changes: 0 additions & 6 deletions lib/ipmi_fru.c
Original file line number Diff line number Diff line change
Expand Up @@ -111,12 +111,6 @@ static inline bool fru_cc_rq2big(int code) {
int
ipmi_spd_print_fru(struct ipmi_intf * intf, uint8_t id);

/* From src/plugins/ipmi_intf.c: */
void
ipmi_intf_set_max_request_data_size(struct ipmi_intf * intf, uint16_t size);
void
ipmi_intf_set_max_response_data_size(struct ipmi_intf * intf, uint16_t size);

extern int verbose;

static void ipmi_fru_read_to_bin(struct ipmi_intf * intf, char * pFileName, uint8_t fruId);
Expand Down
4 changes: 0 additions & 4 deletions lib/ipmi_hpmfwupg.c
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,6 @@
# include <config.h>
#endif

/* From src/plugins/ipmi_intf.c: */
uint16_t
ipmi_intf_get_max_request_data_size(struct ipmi_intf * intf);

extern int verbose;

int HpmfwupgUpgrade(struct ipmi_intf *intf, char *imageFilename,
Expand Down
4 changes: 0 additions & 4 deletions lib/ipmi_sdr.c
Original file line number Diff line number Diff line change
Expand Up @@ -219,10 +219,6 @@ static const char *sensor_type_desc[] = {

void printf_sdr_usage();

/* From src/plugins/ipmi_intf.c: */
uint16_t
ipmi_intf_get_max_response_data_size(struct ipmi_intf * intf);

/** ipmi_sdr_get_unit_string - return units for base/modifier
*
* @param[in] pct Indicates that units are a percentage
Expand Down

0 comments on commit 1724b03

Please sign in to comment.