Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify ingest can be rejected because of large HTTP request body size #277

Open
masih opened this issue Oct 7, 2022 · 0 comments
Open

Comments

@masih
Copy link
Member

masih commented Oct 7, 2022

verify-ingest command uses POST to /multihashes endpoint with a fixed batch size of 4096. Depending on the kind of multihashes being verified the batch size alone is not enough to assure that the HTTP request body size is within the range accepted by an indexer. For example, cid.contact instances use nginx as the ingress controller with default request size of 1MiB.

As a result verifications can fail with status code 400 which can be confusing.

Instead of a fixed batch size, consider batching multihashes by a given max request body size and allow the clients to override the max body size with a default of 1MiB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant