Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Await completion of current requests before shutting down #41

Open
masih opened this issue Oct 19, 2022 · 0 comments
Open

Await completion of current requests before shutting down #41

masih opened this issue Oct 19, 2022 · 0 comments

Comments

@masih
Copy link
Member

masih commented Oct 19, 2022

Reduce downtime for the clients by handling SIGINT gracefully; the service should:

  • become "unready" to prohibit new requests arriving.
  • await completion of ongoing requests.
  • shut down once all is complete.

Once this feature is added, the termination timeout should be adjusted in K8S manifests to allow the container to wait enough for the requests to complete. Note the default timeout is 30 seconds which in the case of indexstar is plenty considering the current HTTP timeout configurations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant