Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified implementation #2

Open
jan-wassenberg opened this issue Sep 20, 2021 · 1 comment
Open

Simplified implementation #2

jan-wassenberg opened this issue Sep 20, 2021 · 1 comment

Comments

@jan-wassenberg
Copy link

Hi, I thought it might be useful to have a simplified (sequential) version of the code.
Please consider the attached code a patch authored and contributed by Google.

I combined all the source files into one header, reduced it to about 1100 lines and added some optional AVX-512 SIMD for classification to see how much of a difference that makes. There are some TODO comments indicating hints for future optimizations.

Note that the code is mostly de-templatized so that symbols are more easily visible in the profiler. For actual use, the Cfg struct should be parameterized on the key type again, and also passed as a parameter to the Sorter class.

@ips4o
Copy link
Owner

ips4o commented Sep 20, 2021

Hi! Thank you for attaching the implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants