Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtualenvs are no longer detected and automatically used #206

Closed
ulope opened this issue Nov 15, 2016 · 5 comments
Closed

Virtualenvs are no longer detected and automatically used #206

ulope opened this issue Nov 15, 2016 · 5 comments
Milestone

Comments

@ulope
Copy link

ulope commented Nov 15, 2016

The automatic detection and usage of a currently active virtualenv seems to have been broken in the last few releases.

Unfortunately I can't name exact versions since I updated my jupyter/ipykernel a few days ago to the currect versions and only now noticed this.

@takluyver
Copy link
Member

Sorry, it was deliberately removed in #96. We can't properly use an active virtualenv if IPython is running outside a the env, and we decided that for kernels running inside Jupyter, the attempt to use it was more confusing than useful.

If you want the old behaviour back, you can put the virtualenv detection code in a startup script.

@takluyver takluyver added this to the no action milestone Nov 15, 2016
@ulope
Copy link
Author

ulope commented Nov 16, 2016

That is really a shame and to be honest I'm quite baffled by this decision. It's not as if you removed the code to reduce maintenance burden (which would be perfectly understandable), but just disabled it in this specific subclass. That seems quite user hostile without a good reason.

@takluyver
Copy link
Member

Sorry about that. The virtualenv integration was never something we could do perfectly, and it doesn't really fit well with the ability of the notebook frontend to now start multiple different kinds of kernels. The conda people have an integration that lets you pick different environments as kernels; I don't much like that either, but we're continuing to think about how to expose environments in notebooks.

@ulope
Copy link
Author

ulope commented Nov 18, 2016

Thanks for the response and also I'm sorry if my previous message came off as entitled or too aggressive (it was a bad day).

I know that maintaining open source software is a difficult task and one usually gets very little recognition for it. So let me thank you very much for making this awesome tool that is ipython, even if I do have a minor quibble on this point :)

@takluyver
Copy link
Member

Thanks. I've seen much nastier messages around many open source projects, but I don't want IPython & Jupyter to slip into that kind of aggressive communication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants