Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #520: run post_execute and post_run_cell on async cells #521

Merged
merged 2 commits into from Jul 5, 2020
Merged

fix #520: run post_execute and post_run_cell on async cells #521

merged 2 commits into from Jul 5, 2020

Conversation

JoaoFelipe
Copy link
Contributor

More details on the issue: #520

@JoaoFelipe
Copy link
Contributor Author

I guess it failed in the CI due to NEP 29 (stop support for 3.6)

@blink1073
Copy link
Member

Mind changing this line to 3.7?

ipykernel/.travis.yml

Line 60 in 8ec2c46

- python: 3.6

@blink1073 blink1073 added this to the 5.4 milestone Jul 4, 2020
@blink1073 blink1073 added the bug label Jul 4, 2020
blink1073
blink1073 approved these changes Jul 5, 2020
View reviewed changes
Copy link
Member

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit f0b0040 into ipython:master Jul 5, 2020
@blink1073
Copy link
Member

Released as part of 5.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JoaoFelipe @blink1073