Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "install_requires" keyword doesn't work with distutils #95

Closed
SnarkBoojum opened this issue Sep 28, 2015 · 6 comments
Closed

The "install_requires" keyword doesn't work with distutils #95

SnarkBoojum opened this issue Sep 28, 2015 · 6 comments
Milestone

Comments

@SnarkBoojum
Copy link

It should be "requires", so I suggest the line:
setup_args['requires'] = setuptools_args['install_requires'] = [
instead of what appears now in setup.py.

@minrk
Copy link
Member

minrk commented Sep 28, 2015

install_requires is only added to setup args when setuptools is already loaded, so it's never passed to plain distutils.

@minrk minrk added this to the no action milestone Sep 28, 2015
@SnarkBoojum
Copy link
Author

Yes, so distutils doesn't get the "requires" it needs, and my debian packaging doesn't pick the dependencies correctly.

@minrk
Copy link
Member

minrk commented Sep 28, 2015

How is the package constructed?

@SnarkBoojum
Copy link
Author

The package is built with a debian tool (pybuild), which calls setup.py with the actual arguments -- and then parses some resulting files to get metadata about the package.

If setup.py's install target uses distutils but distutils' setup doesn't get the 'requires', then the dep information will be lost.

I must admit I don't quite follow why setuptools is used at some steps and not at others [I think I'll hit the problem with quite a few IPython/Jupyter packages... let's discuss here...]

@SnarkBoojum
Copy link
Author

Ok, I added a package-patch to make setuptools used for each and every target -- that way everything works.

@SylvainCorlay
Copy link
Member

@SnarkBoojum - I don't know much about Debian packaging but I was wondering if this type of "package patch" should be contributed to the traitlets repo or if it is an idiosyncrasy of Debian that should not be here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants