Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Android navigation bar respect app theme #101

Closed
iqfareez opened this issue Feb 16, 2022 · 4 comments
Closed

Make Android navigation bar respect app theme #101

iqfareez opened this issue Feb 16, 2022 · 4 comments
Labels
enhancement New feature or request
Projects

Comments

@iqfareez
Copy link
Member

iqfareez commented Feb 16, 2022

The navigation bar should change theme depending on the app.

Example as video below :
First app is Google Chrome app, then i switched to mpt app. Observe the navigation bar line at the bottom

Screenrecorder-2022-02-16-18-20-49-914.mp4
@iqfareez iqfareez added the enhancement New feature or request label Feb 16, 2022
@iqfareez iqfareez added this to To do in App board Feb 16, 2022
@iqfareez
Copy link
Member Author

Screenrecorder-2022-02-21-09-56-11-81.mp4

I guess i did it. Above is recording from sample app.

@iqfareez
Copy link
Member Author

iqfareez commented Feb 23, 2022

Here is the result of the implementation I've made to the mpt (commit will add later)

Note:

  • Just focus on the system navigation bar:
  • All devices running on Android 11

Before (Pixel emulator)

Screenshot_1645419913 (Custom)
Screenshot_1645419926 (Custom)
Screenshot_1645419930 (Custom)
Hd

After (Pixel emulator)

✅ All good

google emulator (1) (Custom)
google emulator (3) (Custom)

The emulator crashes when i try to change to gesture mode, but maybe the result is similar to YES Altitude.
HD

After (Samsung A70)

✅ All good (with buttons and gestures)

samsung (2) (Custom)
samsung (3) (Custom)
samsung (4) (Custom)
samsung (5) (Custom)
HD

After (Redmi Note 11)

✅ Good on gestures

Screenrecorder-2022-02-23-09-47-58-538.mp4

❎ Didn't work well when in buttons mode. (Button not visible on light mode)

Screenrecorder-2022-02-23-09-48-40-93.mp4

After (YES Altitude 4)

✅ All good, but imo gestures in light mode is very subtle)

flutter_01 (Custom)
flutter_02 (Custom)
flutter_03 (Custom)
flutter_04 (Custom)
HD

Summary

Most of the phones shows good result, only few shows the undesired result. I'll try to make this setting as default, but I'll provide a toggle button to on/off the effect.

@iqfareez iqfareez moved this from To do to In progress in App board Feb 23, 2022
@iqfareez iqfareez added the WIP Work in progress label Feb 23, 2022
@iqfareez
Copy link
Member Author

iqfareez commented Mar 3, 2022

Available in Syaaban pre-release

@iqfareez iqfareez moved this from In progress to Done in App board Mar 6, 2022
@iqfareez iqfareez removed the WIP Work in progress label Mar 6, 2022
@iqfareez
Copy link
Member Author

iqfareez commented Mar 6, 2022

Available in Syaaban release. Alhamdulillah. Closing.

@iqfareez iqfareez closed this as completed Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
App board
  
Done
Development

No branches or pull requests

1 participant