Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notification] App lag on theme change #31

Closed
iqfareez opened this issue Nov 29, 2020 · 8 comments
Closed

[Notification] App lag on theme change #31

iqfareez opened this issue Nov 29, 2020 · 8 comments
Labels
bug Something isn't working critical Need quic fix! enhancement New feature or request

Comments

@iqfareez
Copy link
Member

As i stated in releases page:

I noticed that the app become slow / unresponsive for like split seconds. Eg: Transition between splash screen and main UI, also CupertinoButton in Settings page animation lags. This is likely due to notification scheduling that takes time in the background.

This is not a big deal right? I think there an easy fix out there. I'll try to fix this problem.

@iqfareez iqfareez added bug Something isn't working enhancement New feature or request labels Nov 29, 2020
@iqfareez iqfareez changed the title App lag at few places [Notification] App lag on start Nov 30, 2020
@iqfareez
Copy link
Member Author

Since today is the beginning of the month. The issue is much noticeable. When the app start. The app will schedule for upcoming notification. I see here scheduling multiple notifications (5 daily prayer time * 30 days) is the issue. Will try to make it async or limit the number or smth.

@iqfareez
Copy link
Member Author

Proposed workarounds:

Add if statements so that the notification won't get scheduled if it is unnecessary.

@iqfareez iqfareez added the help wanted Extra attention is needed label Nov 30, 2020
@iqfareez iqfareez pinned this issue Nov 30, 2020
@iqfareez
Copy link
Member Author

iqfareez commented Dec 1, 2020

Because of this issue, I had no choice other than to unpublish the app on the Google Play Store to prevent users from giving low rating.

Will republish until the issue is fix partially (or hopefully completely)

@iqfareez
Copy link
Member Author

iqfareez commented Dec 1, 2020

Should be fixed in latest release candidate

@iqfareez iqfareez removed the help wanted Extra attention is needed label Dec 1, 2020
@iqfareez
Copy link
Member Author

iqfareez commented Dec 2, 2020

@iqfareez iqfareez closed this as completed Dec 2, 2020
@iqfareez
Copy link
Member Author

iqfareez commented Dec 3, 2020

Reopen and renamed this issue because it the problem still occurs when user switch theme. When user switch theme GetMaterialApp will be invoked thus 'restarted' the app with selected new theme. So, my hypothesis is that the isolate function didn't work well to 'isolate' the thread ??

At this point I don't know what to do hshhs

@iqfareez iqfareez reopened this Dec 3, 2020
@iqfareez iqfareez changed the title [Notification] App lag on start [Notification] App lag on theme change Dec 3, 2020
@iqfareez iqfareez added the critical Need quic fix! label Dec 16, 2020
@iqfareez
Copy link
Member Author

Should fixed in latest release BETA III
Will push to stable when test pass.

@iqfareez
Copy link
Member Author

pr #43 , should be in PRODUCTION anytime soon

@iqfareez iqfareez unpinned this issue Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working critical Need quic fix! enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant