Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offsetted hijri date #54

Closed
iqfareez opened this issue Mar 16, 2021 · 9 comments · Fixed by #59 or #75
Closed

Offsetted hijri date #54

iqfareez opened this issue Mar 16, 2021 · 9 comments · Fixed by #59 or #75
Labels
bug Something isn't working
Projects

Comments

@iqfareez
Copy link
Member

As per Subia's email:

Assalamu'alaikum. Hari Bulan utk Bln Islam thn Hijrah ini awl sehari.,

I've checked with Google, JAKIM, home calendar and there is indeed some variation in hijri time (refer images). Perhaps we can add date offset feature to the app. Before Ramadhan Inshallah.

image
image

Debug

  ----------------------APP--------------------------
                        Version: 1.12.76-stable, VersionCode: 36
                        ---------------------DEVICE---------------------
                        Android 10 (SDK 29), Xiaomi Redmi Note 9 Pro
                        Hardware: qcom
                        Screen size (392.7, 825.5) DiP
                        PixRatio 2.75
@iqfareez iqfareez added bug Something isn't working feature request labels Mar 16, 2021
@iqfareez
Copy link
Member Author

Received report from other users from email. Awallaa mapleee hahhahahha uhuhu bnyak kerje do sorry

@iqfareez
Copy link
Member Author

Using: ahmedoid/hijri_date#6 (comment)

@iqfareez iqfareez linked a pull request Mar 28, 2021 that will close this issue
@iqfareez
Copy link
Member Author

@iqfareez
Copy link
Member Author

iqfareez commented Apr 13, 2021

Reopen. Some folks noticed that the date is wrong where it supposed to show 1 Ramadan, but instead it shows 30 Shaaban.

Please refresh the date. It's already 1st of Ramadhan NOT 30th of Sya'aban

change to ramadhan 13/4/21. 1 ramadhan 1442

Thank you both of you submitting the report. It really helps. I'm working on temporary solution asap. A long term solution is already in mind, but I think it will take quite some time to implement.

@iqfareez iqfareez reopened this Apr 13, 2021
@iqfareez iqfareez pinned this issue Apr 13, 2021
iqfareez added a commit that referenced this issue Apr 13, 2021
@iqfareez
Copy link
Member Author

Someone reported:

Salam. Kalendar islam tidak update. Lewat sehari.

So, I've no idea how to implement Remote Config in the app ahhaah

iqfareez added a commit that referenced this issue Jul 23, 2021
Hijri offset data now fetched from the server #54
@iqfareez
Copy link
Member Author

Done. Pretty easy implementation actually. Test pre-release app now: https://github.com/iqfareez/app_waktu_solat_malaysia/releases/tag/1.24.132-pre%2B62

@iqfareez iqfareez linked a pull request Jul 23, 2021 that will close this issue
@iqfareez
Copy link
Member Author

iqfareez commented Jul 25, 2021

Quickly made a web app to know how many days I need to offset

https://mpt-hijri-converter.web.app/#/

@iqfareez iqfareez unpinned this issue Aug 31, 2021
@iqfareez
Copy link
Member Author

iqfareez commented Feb 2, 2022

Reopening this issue.

On 2 Feb 2022, it supposed to be 30 J.Akhir (based on Jakim), but the app shows 1 Rejab.

Attempt to offset the hijri date also failed as there is no 30 J.Akhir available.

Hijri.Converter.and.1.more.page.-.Personal.-.Microsoft.Edge.2022-02-02.09-00-40.mp4

Thinking of other viable and long term solution, maybe just use the prayer data.

@iqfareez iqfareez reopened this Feb 2, 2022
@iqfareez iqfareez added this to the Ramadan Milestone milestone Feb 4, 2022
@iqfareez iqfareez added the WIP Work in progress label Feb 5, 2022
@iqfareez iqfareez added this to In progress in App board Feb 9, 2022
iqfareez added a commit that referenced this issue Feb 17, 2022
@iqfareez iqfareez moved this from In progress to Done in App board Feb 20, 2022
@iqfareez
Copy link
Member Author

iqfareez commented Feb 26, 2022

alhamdulillah

Fixed in latest release,
We now use the hijri date available together during prayer times api calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
App board
  
Done
1 participant