Added url validation for starting with http, https #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added server url validation, ClientConfigurationError Exception
hay-k
suggested changes
Feb 10, 2022
hay-k
suggested changes
Feb 10, 2022
|
@WingCode Thanks for your pull request. I have reviewed it and requested some changes above. |
Refactor changelog for cleaner statement from review Co-authored-by: Hayk Sargsyan <52532457+hay-k@users.noreply.github.com>
Improved url schema check with "http:", "https:" and better exception message from review Co-authored-by: Hayk Sargsyan <52532457+hay-k@users.noreply.github.com>
WingCode
commented
Feb 20, 2022
hay-k
suggested changes
Feb 22, 2022
Added empty line at end of file to comply with PEP 8 standard Co-authored-by: Hayk Sargsyan <52532457+hay-k@users.noreply.github.com>
hay-k
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validation (starting with http, https) is expected by the docstring but not enforced.
It might be helpful to fail early and fast since there might be some prior resource intensive steps before utilising the IQM client.