Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made a monero compatible version #313

Open
honzapatCZ opened this issue Nov 26, 2019 · 3 comments
Open

Made a monero compatible version #313

honzapatCZ opened this issue Nov 26, 2019 · 3 comments

Comments

@honzapatCZ
Copy link

I ve applied a little bit of magic and made a monero compatible explorer based of this in the main part it only modifies 2 files(for accuracy of numbers it modifies the views too), api doesnt work and things that arent possible in monero arent available "surprisingly" too.
I call it Moquidus https://github.com/honzapatCZ/Moquidus-Explorer
There could be some for example a link to it in the readme md file, so someone who thought it will work with monero, tried it and it doesnt work would have easy replacement, basically its only needed to clone the new one replace the customizations(settings themes images etc.), reinit so it download all the modules and boom its done.

@TheHolyRoger
Copy link
Collaborator

@honzapatCZ have you got a link to this working somewhere?

@honzapatCZ
Copy link
Author

honzapatCZ commented Dec 30, 2019

http://81.201.57.193:3001 if you are lucky enough you can catch it there, i have some problems with mongodb not starting up as I upgraded my wp from mysql and it also like to go to sleep whenever it wants, but other than that it should sometimes work.

You are better of taking some forkcoin of monero, or just use testnet of monero and test it yourself, you can see how I patched some parts of it to work.

@uaktags
Copy link
Collaborator

uaktags commented Dec 30, 2019

I'll keep trying at it to see if I can get it to load (though it may be good for me to just spin up monero or aeon to test with.

However, you should really look into reversing some of your changes. You've commented out a fair number of functions, and (since your issues creation) we've updated a bit. The commenting out has introduced alot of white space, and overall could just be cleaned up. Instead, I'd look into what was actually needed to be changed, and try to keep the changes close to the original source as possible so it doesn't get flagged as the whole thing being deleted and added.

Example:
lib/database.js line 138 and on for the lib.get_block section.

I'm not sure why lib/explorer.js needed to be changed, but my guess is you're looking to do what I did by removing bitcoin-node-api, and what was also brought into place with 1.7.2. Basically instead of coding the RPC "real_request" into explorer.js, we've opted to use bitcoin-core npm module.

Your method has the benefit of calling things like "get_last_block_header" which we don't use, but it leads to this big discrepancy in commit changes which is going to make it harder for you to maintain and acquire changes/patches we create.

This however, does bring up a discussion we're having (i'm kinda the one thats mentioning it at the moment) as well as something I started tackling in my repo that I'll hopefully polish up and bring over. Currently, I don't think bitcoin-core will recognize these commands either, without some finesse. This is where https://github.com/uaktags/explorer/blob/06d8229a97548633dd1de8b013b37b22f93c28bd/app.js#L22-L35 tackled that idea. That allows us use commands that bitcoin-core otherwise wouldn't know about, but you still need a way to use those commands which is where I do see new code being needed.

Much to ponder, we have.

@TheHolyRoger TheHolyRoger added this to the Coin-Commands milestone Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants