Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python fusion test does not run #58

Closed
ftynse opened this issue Nov 29, 2021 · 3 comments
Closed

python fusion test does not run #58

ftynse opened this issue Nov 29, 2021 · 3 comments

Comments

@ftynse
Copy link
Contributor

ftynse commented Nov 29, 2021

The python/fusion/test.py has the main function, but is never called, so running it with python -m does nothing and predictably succeeds.

@gysit
Copy link
Contributor

gysit commented Nov 29, 2021

After #55 the main function will be called. However, the test does only compile and print the IR for now. Adding verification and performance measurements is still a TODO.

@MaheshRavishankar
Copy link
Contributor

If you see the TODO here (https://github.com/google/iree-llvm-sandbox/blob/fc5dcf3d511bfdaa1033475541292191aaeaa0ce/python/fusion/test.py#L52) it should work when run manually (comments use bazel but same should work with CMake). Issue when I tried this first time around is that I didnt have a driver for the lit tests from bazel. I have no idea how any of the python stuff is setup, but would be great to enable this. I know core already has this.

@ftynse
Copy link
Contributor Author

ftynse commented Nov 30, 2021

Well it does "run" and does nothing because main is never called, bazel or not. The only check performed by FileCheck is the absence of "FAILURE" printed, which is the case when the code does nothing and prints nothing.

@ftynse ftynse closed this as completed in d56cc79 Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants