Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better filtering for benchmark results posted on pull requests #6109

Closed
3 tasks done
antiagainst opened this issue Jun 4, 2021 · 0 comments · Fixed by #6124
Closed
3 tasks done

Better filtering for benchmark results posted on pull requests #6109

antiagainst opened this issue Jun 4, 2021 · 0 comments · Fixed by #6124
Assignees
@antiagainst
Labels
infrastructure/benchmark Relating to benchmarking infrastructure infrastructure Relating to build systems, CI, or testing
Projects
Benchmarking Flow Improvement

Comments

@antiagainst
Copy link
Contributor

antiagainst commented Jun 4, 2021 •
edited
Loading

Right now we just post all the benchmark results to a pull request if it has the buildkite:benchmark tag. It can be too much information as we collect more and more benchmark cases. Better to

  • Fiter them properly and just omit those under a certain threshold when comparing with the base results
  • Split into separate tables for improved/regressed benchmarks
  • Sort according to the ratio
@antiagainst antiagainst added this to To do in Benchmarking Flow Improvement via automation Jun 4, 2021
@antiagainst antiagainst added infrastructure Relating to build systems, CI, or testing infrastructure/benchmark Relating to benchmarking infrastructure labels Jun 4, 2021
@antiagainst antiagainst mentioned this issue Jun 5, 2021
Merged
@antiagainst antiagainst linked a pull request Jun 5, 2021 that will close this issue
Abbreviate benchmark results posted to pull requests #6124
Merged
@antiagainst antiagainst self-assigned this Jun 7, 2021
Benchmarking Flow Improvement automation moved this from To do to Done Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antiagainst antiagainst

Labels
infrastructure/benchmark Relating to benchmarking infrastructure infrastructure Relating to build systems, CI, or testing
Projects
No open projects
Benchmarking Flow Improvement
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Abbreviate benchmark results posted to pull requests antiagainst/iree
1 participant
@antiagainst