Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add state of reviewed file #17

Open
miguel-botelho opened this issue Dec 12, 2018 · 4 comments
Open

Feature Request: Add state of reviewed file #17

miguel-botelho opened this issue Dec 12, 2018 · 4 comments

Comments

@miguel-botelho
Copy link

I use this extension a lot for doing Code Reviews on Github. Something that would make my job a lot easier would be the ability to select which file I had already reviewed or not.

Do you think that's something that is easy to do, at the moment? (I think it may not be trivial, since there's no database or something that stores any type of state)

Also, can you give me some guidelines on how to contribute to this project, so I could maybe start developing this, if I have enough time?

@irek02
Copy link
Owner

irek02 commented Dec 15, 2018

Hey @miguel-botelho, I can see how this feature can be useful. And, using Local Storage can be a good enough solution to keep track of checked files.

My goal is to keep the extension as simple as possible though. But nothing should be stopping you from forking the repo and adding that yourself! To get started:

  1. Fork and clone the repo to your machine
  2. Run npm install
  3. Modify source files to implement the feature
  4. Build the distribution files using npm run build
  5. Install the distribution to your Chrome as a custom extension using Development mode
  6. Open any github PR and pop your modified extension by pressing z to see if it works! (you might want to disable the original extension though, otherwise, it might conflict with your custom one)

@miguel-botelho
Copy link
Author

Hey @irek02, thanks for the reply! Do you think I could fork your project and develop on top of it? If I decide to publish it, can I do it or do you want it to be associated with your own Chrome application?

@irek02
Copy link
Owner

irek02 commented Dec 20, 2018

hey @miguel-botelho , you can totally fork it and add the feature on top of it. If you want to publish it as your own extension I think it will be fine with me. It would be nice if you let me know before you do so though. Maybe I would be able to incorporate your feature into my extension and have it available under a setting so that it only appears if you turn it on.

@miguel-botelho
Copy link
Author

Thanks for the answer. Whenever I have time, I'll start developing it and let you know when it's finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants