Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update slice with mouse scroll #10

Closed
Irev-Dev opened this issue Oct 9, 2018 · 4 comments
Closed

Update slice with mouse scroll #10

Irev-Dev opened this issue Oct 9, 2018 · 4 comments
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@Irev-Dev
Copy link
Owner

Irev-Dev commented Oct 9, 2018 •
edited
Loading

Feature request: Scrolling the mouse when on an image will scroll through slices on that view.

Currently when you click and drag and on one image the other two update (showing a cross-section that matches the mouse coordinates), but it would be good and intuitive to be-able to scroll throw the slices of the images you are currently mousing over by scrolling the mouse.

Should be reasonably easy for someone to have a go at as we already have event listeners setup, just more will need to be added. Have a look at what's happening in updateCanvases() and see if that function should be updated or a new function created. The current slice locations are stored in this.currentView so this should only need to be incremented/decremented and then existing functions called to update the canvases.
@Irev-Dev Irev-Dev added help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest labels Oct 9, 2018
@elistone
Copy link
Contributor

elistone commented Oct 9, 2018

I can look into this one.

@elistone
Copy link
Contributor

elistone commented Oct 9, 2018

Sadly I'm struggling with this one. Someone else is welcome to jump in on it.

@eugeniumegherea
Copy link

I am going to look at this one

eugeniumegherea pushed a commit to eugeniumegherea/MRI-Volume-Slice that referenced this issue Oct 9, 2018
feat: Irev-Dev#10 implement scrolling using mouse wheel
de65272
@eugeniumegherea eugeniumegherea mentioned this issue Oct 9, 2018
Merged
Irev-Dev added a commit that referenced this issue Oct 10, 2018
@Irev-Dev
Merge pull request #13 from eugeniumegherea/mouse_wheel_scroll
59935a0 
Impelements #10 🎉🎉🎉🎉🎉🎉 Thanks @eugeniumegherea
@Irev-Dev
Copy link
Owner Author

fixed with PR #13 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@elistone @eugeniumegherea @Irev-Dev