Reference global.XMLHttpRequest directly so XMLHttpRequest can be mocked #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- check for global.XMLHttpRequest directly instead of what global.XMLHttRequest referenced when the library was first parsed - reference global.XMLHttpRequest constructor instead of the constructor that was dereferenced when the library was first parsed - reference global.XMLHttpRequest status properties directly instead of the properties of the prototype of the constructor that was dereferenced when the library was first parsed This will allow mocking libraries that rely on being able to replace the reference to global.XMLHttpRequest with a mock XMLHttpRequest object that can be programmatically manipulated. Such libraries include the jasmine-ajax plugin. I'm sure there are others. It's a little more typing, but it fixes a big bug.
|
+1 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that was dereferenced when the library was first parsed
the properties of the prototype of the constructor that was dereferenced
when the library was first parsed
This will allow mocking libraries that rely on being able to replace
the reference to global.XMLHttpRequest with a mock XMLHttpRequest object
that can be programmatically manipulated.
Such libraries include the jasmine-ajax plugin. I'm sure there are
others.
It's a little more typing, but it fixes a big bug.