Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Year sometimes incorrectly used as season and episode number #22

Closed
IrishPrime opened this issue May 15, 2016 · 1 comment
Closed

Year sometimes incorrectly used as season and episode number #22

IrishPrime opened this issue May 15, 2016 · 1 comment
Assignees
@IrishPrime
Labels
bug

Comments

@IrishPrime
Copy link
Owner

Some shows include a year as part of the title (generally to differentiate them from previously aired shows with the same name). Sometimes the year will be recognized as the the season and episode number while the actual season and episode number will be used as the title.

the.flash.2014.215.hdtv.mp4, for example, will yield The Flash -20.14- 215.mp4.

It's difficult to be certain if a four digit number is the year or the season and episode number when the original name doesn't use the SXXEXX format.
@IrishPrime IrishPrime self-assigned this May 15, 2016
@IrishPrime IrishPrime added the bug label May 15, 2016
@IrishPrime
Copy link
Owner Author

It seems like I can just add another pattern which checks for a four digit group (the year - \d{4}) and then my usual season and episode number check which doesn't use the SXXEXX format (\d{1,2}\d{2}).

This pattern would need to be near the top of the priority list.

IrishPrime added a commit that referenced this issue May 21, 2016
@IrishPrime
Add pattern to better handle a year specifier after the series name
912a128 
- Add a pattern which should more accurately determine whether a four
  digit string after the name of the series is the year the series began
  or the season and episode number. This also prevents the actual
  season and episode number from being interpreted as the title of the
  episode.
- Add test cases to exercise the new pattern.
- Resolves #22.
@IrishPrime IrishPrime mentioned this issue May 21, 2016
Merged
IrishPrime added a commit that referenced this issue May 21, 2016
@IrishPrime
Add pattern to better handle a year specifier after the series name (#23
9b4ed03 
)

- Add a pattern which should more accurately determine whether a four
  digit string after the name of the series is the year the series began
  or the season and episode number. This also prevents the actual
  season and episode number from being interpreted as the title of the
  episode.
- Add test cases to exercise the new pattern.
- Resolves #22.
IrishPrime added a commit that referenced this issue Feb 23, 2019
@IrishPrime
Add pattern to better handle a year specifier after the series name (#23
3d49f2c 
)

- Add a pattern which should more accurately determine whether a four
  digit string after the name of the series is the year the series began
  or the season and episode number. This also prevents the actual
  season and episode number from being interpreted as the title of the
  episode.
- Add test cases to exercise the new pattern.
- Resolves #22.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IrishPrime IrishPrime

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@IrishPrime