Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fill out the englishnames.go name lists #2

Closed
BenOvermyer opened this issue Oct 3, 2018 · 4 comments
Closed

Fill out the englishnames.go name lists #2

BenOvermyer opened this issue Oct 3, 2018 · 4 comments
Labels
good first issue Good for newcomers Hacktoberfest Good issues for Hacktoberfest

Comments

@BenOvermyer
Copy link
Member

Using a name list from somewhere on the Web, fill out the English names in englishnames.go.
@BenOvermyer BenOvermyer added good first issue Good for newcomers Hacktoberfest Good issues for Hacktoberfest labels Oct 3, 2018
@dbyington
Copy link
Contributor

I'm game.
Are you looking for just a static slice of names or something that pulls a random name from somewhere?

@BenOvermyer
Copy link
Member Author

@dbyington A static slice of names. I want to avoid dependencies on external APIs or even network availability.

@dbyington
Copy link
Contributor

Cool.
Mind if keep line length down to 140 chars? I could go longer if you prefer, just looking to keep it somewhat readable.

@BenOvermyer
Copy link
Member Author

Sure, that's fine. I just merged a PR for German names that has nice formatting. You could use that as an example.

@dbyington dbyington mentioned this issue Oct 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Hacktoberfest Good issues for Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BenOvermyer @dbyington