Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a case-insensitive comparision for the pattern "chunked" for "Transfer-Encoding" #78

Closed
wants to merge 1 commit into from

Conversation

poona
Copy link
Contributor

@poona poona commented Jul 22, 2014

While verifying the value of the "Transfer-Encoding" header, libhtp does a
case-sensitive comparison for the value "chunked", thus pushing out
case-sensitive values such as "Chunked".

Convert the case-sensitive comparison to a case-insensitive one by using
bstr_cmp_c_nocase(), instead of the currently used bstr_cmp_c().

…oes a

case-sensitive comparison for the value "chunked", thus pushing out
case-sensitive values such as "Chunked".

Convert the case-sensitive comparison to a case-insensitive one by using
bstr_cmp_c_nocase(), instead of the currently used bstr_cmp_c().
@inliniac
Copy link
Contributor

Might also be good to have this go into the 0.5.x branch.

@ivanr
Copy link
Contributor

ivanr commented Jul 22, 2014

It will go into 0.5.x. In the future, please submit pull requests against either the stable (now 0.5.x) or development branch (now 0.6.x). Master follows stable branch releases.

@ivanr
Copy link
Contributor

ivanr commented Jul 22, 2014

If possible, please send me an example of a T-E header with non-lowercase usage of the chunked encoding. A complete HTTP transaction is best. Thanks.

@poona
Copy link
Contributor Author

poona commented Jul 22, 2014

On Tue, Jul 22, 2014 at 4:53 PM, Ivan Ristić notifications@github.com
wrote:

It will go into 0.5.x. In the future, please submit pull requests against
either the stable (now 0.5.x) or development branch (now 0.6.x). Master
follows stable branch releases.


Reply to this email directly or view it on GitHub
#78 (comment).

Okay.


Anoop Saldanha

http://www.poona.me

@poona
Copy link
Contributor Author

poona commented Jul 22, 2014

On Tue, Jul 22, 2014 at 4:54 PM, Ivan Ristić notifications@github.com
wrote:

If possible, please send me an example of a T-E header with non-lowercase
usage of the chunked encoding. Thanks.


Reply to this email directly or view it on GitHub
#78 (comment).

I tried a simple request, as well as a response, with T-E set as "Chunked",
"CHUNKED" and other such combinations. Both, Apache-2.4.7 and firefox-30.0
accepted the data stream.


Anoop Saldanha

http://www.poona.me

@ivanr
Copy link
Contributor

ivanr commented Jul 31, 2014

Added to the 0.5.x and 0.6.x branches.

@ivanr ivanr closed this Jul 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants