Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Plugin nodes unknown in subgraphs #114

Closed
1 task done
Swimburger opened this issue Sep 11, 2023 · 10 comments
Closed
1 task done

[Bug]: Plugin nodes unknown in subgraphs #114

Swimburger opened this issue Sep 11, 2023 · 10 comments
Labels
bug Something isn't working

Comments

@Swimburger
Copy link
Collaborator

What happened?

When I add AssemblyAI nodes into a subgraph, and call the subgraph from another graph, I get the following error:

Error: Unknown node type: assemblyAiTranscribeAudio
Error: Unknown node type: assemblyAiLemurQa

What was the expected functionality?

The nodes should be known and work.

Describe your environment

macOS using the latest Rivet release from downloads page.

Relevant log output

No response

Relevant screenshots

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Swimburger Swimburger added the bug Something isn't working label Sep 11, 2023
@Swimburger
Copy link
Collaborator Author

The same error occurs when running the graph from node.js:

/Users/niels/RivetPodcastQnA/node_modules/@ironclad/rivet-core/dist/cjs/bundle.cjs:786
      throw new Error(`Unknown node type: ${type}`);
            ^

Error: Unknown node type: assemblyAiTranscribeAudio
    at NodeRegistration.createDynamicImpl (/Users/niels/RivetPodcastQnA/node_modules/@ironclad/rivet-core/dist/cjs/bundle.cjs:786:13)
    at new _GraphProcessor (/Users/niels/RivetPodcastQnA/node_modules/@ironclad/rivet-core/dist/cjs/bundle.cjs:7041:53)
    at createProcessor (/Users/niels/RivetPodcastQnA/node_modules/@ironclad/rivet-node/dist/cjs/bundle.cjs:144:21)
    at runGraph (/Users/niels/RivetPodcastQnA/node_modules/@ironclad/rivet-node/dist/cjs/bundle.cjs:249:25)
    at runGraphInFile (/Users/niels/RivetPodcastQnA/node_modules/@ironclad/rivet-node/dist/cjs/bundle.cjs:132:10)

Node.js v20.5.1

@abrenneke
Copy link
Collaborator

Ah thanks for reporting, I don't think it should be that difficult of a fix.

@abrenneke
Copy link
Collaborator

Fixed in #118

@abrenneke
Copy link
Collaborator

@all-contributors please add @Swimburger for bug

@allcontributors
Copy link
Contributor

@abrenneke

I've put up a pull request to add @Swimburger! 🎉

@Swimburger
Copy link
Collaborator Author

Thank you for moving fast on this! This would've blocked our tutorial :)

@Swimburger
Copy link
Collaborator Author

I'm still getting the error when using it from node.js:

/Users/niels/RivetPodcastQnA/node_modules/@ironclad/rivet-core/dist/cjs/bundle.cjs:788
      throw new Error(`Unknown node type: ${type}`);
            ^

Error: Unknown node type: assemblyAiTranscribeAudio
    at NodeRegistration.createDynamicImpl (/Users/niels/RivetPodcastQnA/node_modules/@ironclad/rivet-core/dist/cjs/bundle.cjs:788:13)
    at new _GraphProcessor (/Users/niels/RivetPodcastQnA/node_modules/@ironclad/rivet-core/dist/cjs/bundle.cjs:7264:53)
    at createProcessor (/Users/niels/RivetPodcastQnA/node_modules/@ironclad/rivet-node/dist/cjs/bundle.cjs:144:21)
    at runGraph (/Users/niels/RivetPodcastQnA/node_modules/@ironclad/rivet-node/dist/cjs/bundle.cjs:249:25)
    at runGraphInFile (/Users/niels/RivetPodcastQnA/node_modules/@ironclad/rivet-node/dist/cjs/bundle.cjs:132:10)

Node.js v20.5.1

How are we supposed to use built-in plugins from Node.js?

@abrenneke
Copy link
Collaborator

That looks correct if you haven't registered the plugin on the node side - have you called globalRivetNodeRegistry.registerPlugin(plugins.assemblyAi)?

@Swimburger
Copy link
Collaborator Author

Splendid, that works! I was expecting something like this because in the Rivet UI you also need to enable the plugin.
I just couldn't find how to do it. Is the documented anywhere? Maybe it should be part of a sample?

@abrenneke
Copy link
Collaborator

// TODO 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants