Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Machine Deletion Logic in Integration Tests #218

Open
so-sahu opened this issue Mar 5, 2024 · 0 comments · May be fixed by #232
Open

Refactor Machine Deletion Logic in Integration Tests #218

so-sahu opened this issue Mar 5, 2024 · 0 comments · May be fixed by #232
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers prio-low

Comments

@so-sahu
Copy link
Contributor

so-sahu commented Mar 5, 2024

Description

The current machine deletion logic in integration tests is causing multiple unnecessary calls to the libvirt-provider and flooding of logs in the console as seen here. This is because the machine deletion is called inside the Eventually block, as seen in this example.

Proposed Solution

Refactor the machine deletion logic in integration tests to avoid unnecessary calls and log flooding.

Expected Behavior

Machine deletion logic should be optimized to avoid multiple unnecessary calls and log flooding.

Additional Context

This enhancement will improve the efficiency and performance of integration tests by optimizing the machine deletion logic.

@so-sahu so-sahu added enhancement New feature or request prio-low labels Mar 5, 2024
@lukas016 lukas016 added the good first issue Good for newcomers label Mar 13, 2024
@kasabe28 kasabe28 self-assigned this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers prio-low
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

3 participants