Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Mac M1 #99

Closed
cjyar opened this issue Jun 6, 2022 · 2 comments
Closed

Support Mac M1 #99

cjyar opened this issue Jun 6, 2022 · 2 comments

Comments

@cjyar
Copy link
Contributor

cjyar commented Jun 6, 2022

https://github.com/IronCoreLabs/recrypt-node-binding/runs/6751924442?check_suite_focus=true seems to indicate that we need to support arm64 on Mac:

dlopen(/Users/ironcore/actions-runner/_work/recrypt-node-binding/recrypt-node-binding/bin-package/index.node, 0x0001): tried: '/Users/ironcore/actions-runner/_work/recrypt-node-binding/recrypt-node-binding/bin-package/index.node' (mach-o file, but is an incompatible architecture (have 'arm64', need 'x86_64')), '/usr/local/lib/index.node' (no such file), '/usr/lib/index.node' (no such file)
@BobWall23
Copy link
Member

Hopefully just add arm64 to the build matrix.

@giarc3
Copy link
Member

giarc3 commented Jun 17, 2022

Should be fixed as part of #100. The setup-node action takes an optional architecture parameter that we weren't passing, so it was defaulting to x86_64 for all of them. I added arch: arm64 to the necessary parts of our build matrix and used it for the setup-node action.

@giarc3 giarc3 closed this as completed Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants