Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing greetings #33

Closed
sathe-aditya opened this issue Aug 14, 2016 · 3 comments
Closed

Increasing greetings #33

sathe-aditya opened this issue Aug 14, 2016 · 3 comments

Comments

@sathe-aditya
Copy link

Hello!
I'm new here, and was exploring around, when I observed that 'personality.txt' and 'personality.py' have greetings specific to a certain time of the day.
I feel that maybe an addition of the day could be made, which can incorporate sentences such as, 'How is your Sunday going?', or 'TGIF! What are your plans for tonight?'
This can increase the number of sentences W.I.L.L. can greet with!

Again, I am new here and have just observed this, please guide me in the correct direction if I am going wrong! :)

@ironman5366
Copy link
Owner

Hi! Thanks for taking interest in W.I.L.L! Those are great suggestions for further greetings, and I'd be happy to implement them. However, I'll have to do it down the road. Right now, I'm working on an overhaul of the framework. But once it's finished, I'd be happy to put these into the new config. I'll keep this issue open so I can remember to do that when I merge the new framework through. Thanks!

@sathe-aditya
Copy link
Author

Hey! It's great that my suggestions are of some value. :)
If you don't mind, may I work on it and issue a pull request?

@ironman5366
Copy link
Owner

Sure! However, when the dev branch gets pulled through in a month or so, it's gonna be overwritten. I'd suggest keeping your own version controlled greetings and then I'll integrate them when the frameworks settled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants