Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vaults.ps1 #1470

Open
adamdriscoll opened this issue Aug 11, 2022 · 3 comments
Open

Vaults.ps1 #1470

adamdriscoll opened this issue Aug 11, 2022 · 3 comments
Labels
Core This requires a change to core functionality of the platform. enhancement New feature or request PowerShell Universal Issue relates to PowerShell Universal.

Comments

@adamdriscoll
Copy link
Member

adamdriscoll commented Aug 11, 2022

Summary of the new feature / enhancement

We need a way to more consistently ensure that secret vaults are registered. In some environments, like Azure, the secret vault registrations aren't persistent between restarts of the web app. This leads to having to schedule triggered scripts at startup and then hope that they finish at the right time before variables are read.

With a vaults.ps1, we could also add a new UI page to view registered vaults, their vault types, parameters used to configure them and the count of secrets available. We could also make it so you could manage secrets in the vaults (add, delete, etc). We need to make sure it's clear that a variable is still required (maybe a create variable button?) for scripts to use secrets.

I'm considering not introducing a new cmdlet for vaults but to use the SecretManagement cmdlets to list and manage vaults. We should be able to get all the info we need from those cmdlets.

Proposed technical implementation details (optional)

No response

@adamdriscoll adamdriscoll added enhancement New feature or request PowerShell Universal Issue relates to PowerShell Universal. labels Aug 11, 2022
@adamdriscoll
Copy link
Member Author

This issue has been mentioned on Ironman Software Forums. There might be relevant details there:

https://forums.ironmansoftware.com/t/azure-keyvault-secret-variables/7423/12

@mabster
Copy link

mabster commented Aug 17, 2022

Loving this idea more and more. Azure restarted our app service unexpected last night, and when I got in this morning, none of the morning's scheduled scripts had run successfully 'coz they couldn't get to our secrets. An official "vaults.ps1" that runs at the appropriate time to register the KeyVault would give me some peace of mind! :)

Obviously registering the KeyVault as a vault means you need to be connected to Azure ... would the Connect-AzAccount call occur within vaults.ps1, or do you have other ideas on where that could happen?

@adamdriscoll
Copy link
Member Author

@mabster - Yeah. I assuming Connect-AzAccount would happen in the vaults.ps1.

@adamdriscoll adamdriscoll removed this from the PowerShell Universal 3.3.0 milestone Sep 12, 2022
@adamdriscoll adamdriscoll added the Core This requires a change to core functionality of the platform. label Jan 12, 2023
@adamdriscoll adamdriscoll removed this from the PowerShell Universal 4.1 milestone Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core This requires a change to core functionality of the platform. enhancement New feature or request PowerShell Universal Issue relates to PowerShell Universal.
Projects
None yet
Development

No branches or pull requests

2 participants