Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TinyMCE - Dark Mode #1859

Closed
donlent opened this issue Dec 28, 2022 · 6 comments
Closed

TinyMCE - Dark Mode #1859

donlent opened this issue Dec 28, 2022 · 6 comments
Labels
completed The issue has been completed but is not yet released. enhancement New feature or request PowerShell Universal Issue relates to PowerShell Universal. Quality-of-Life This issue relates to a quality-of-life improvement.

Comments

@donlent
Copy link

donlent commented Dec 28, 2022

Summary of the new feature / enhancement

TinyMCE supports Dark Mode.
image

It would be really cool if you could include / allow the usage of the following additionalTinyMCEOptions:

$TinyMCEOptions = @{
                    skin = 'oxide-dark'
                    content_css = 'dark'
}

Thanks a lot in advance!

Proposed technical implementation details (optional)

https://www.tiny.cloud/blog/dark-mode-tinymce-rich-text-editor/

@donlent donlent added enhancement New feature or request PowerShell Universal Issue relates to PowerShell Universal. labels Dec 28, 2022
@donlent
Copy link
Author

donlent commented Feb 14, 2023

Dear @adamdriscoll and @mattselle
Sorry for bothering on that but is that something that could be achieved similar to how you implemented it here?

From your 3.8 release notes:
"- Added -LightTheme-DarkTheme to New-UDCodeEditor"
#2016

And if you could in the meantime also implement the following options, that would be awesome!! 😊
image

If it's not planned, could you write a blog post or something on how we can modify existing components?
I know you have some examples here and there:
https://docs.powershelluniversal.com/userinterfaces/dashboards/components/custom-components/building-custom-components
https://blog.ironmansoftware.com/universal-dashboard-custom-components/

But as a non-developer I really do not understand how to adapt these techniques to already existing components in PSU. Is that even possible? Or would I really have to implement a New-UDTinyMCE2 by myself starting from scratch?

Thanks for your clarification on this one as well!

Kind regards,
Don

@adamdriscoll
Copy link
Member

This issue has been mentioned on Ironman Software Forums. There might be relevant details there:

https://forums.ironmansoftware.com/t/using-tinymce-with-a-stepper-component-in-universal-dashboard/7614/3

@donlent
Copy link
Author

donlent commented Mar 10, 2023

Hey all!
Sorry just stumbled again over this topic and wanted to share an additional thought with you:
Maybe the implementation should be as transparent like with this issue here:
#2016

Probably this one makes more sense... if the theme is light => use light mode, if dark => dark...

Would really be cool if this enhancement could make it into an upcoming release... 🤗
Thanks a lot for your efforts!

Best regards,
Don

@adamdriscoll adamdriscoll added this to the PowerShell Universal 4.0 milestone Apr 3, 2023
@Omzig
Copy link
Collaborator

Omzig commented Apr 17, 2023

Maybe the implementation should be as transparent like with this issue here:

@mattselle; Yes, please tie it to the theme, just like the work i had done on the CodeEditor, the UDCodeEditor works perfectly.

@Omzig Omzig added the Quality-of-Life This issue relates to a quality-of-life improvement. label Apr 17, 2023
@adamdriscoll
Copy link
Member

adamdriscoll commented Apr 27, 2023

This component has been moved to our modules repo. https://github.com/ironmansoftware/universal-modules/tree/main/Components/TinyMCE

It now supports dark mode and checks the current theme setting to load the proper style. You can install this module with:

Install-Module Universal.Components.TinyMCE

@adamdriscoll adamdriscoll added the completed The issue has been completed but is not yet released. label Apr 27, 2023
@donlent
Copy link
Author

donlent commented Apr 27, 2023

Thanks a lot @adamdriscoll! Can't wait to implement it in the upcoming PSU Version!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed The issue has been completed but is not yet released. enhancement New feature or request PowerShell Universal Issue relates to PowerShell Universal. Quality-of-Life This issue relates to a quality-of-life improvement.
Projects
None yet
Development

No branches or pull requests

4 participants