Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file change on HD does not show up in admin site #1984

Closed
Omzig opened this issue Jan 24, 2023 · 12 comments
Closed

file change on HD does not show up in admin site #1984

Omzig opened this issue Jan 24, 2023 · 12 comments
Labels
bug Something isn't working completed The issue has been completed but is not yet released. Core This requires a change to core functionality of the platform. P4 - low Bug has minimal impact, general usage not affected. PowerShell Universal Issue relates to PowerShell Universal. Quality-of-Life This issue relates to a quality-of-life improvement.

Comments

@Omzig
Copy link
Collaborator

Omzig commented Jan 24, 2023

Steps to Reproduce

when i change a file on the hard drive the pages\page.ps1 file does not reflect in the admin site till after an app pool recycle #sometimes

Expected behavior

show file on HD that was changed manually

Actual behavior

displays cached version of the file

Environment data

PSU: 3.7.7 - 3.8.12
IIS: Nested

Visuals

No response

Workaround

Recycle App Pool

@Omzig Omzig added bug Something isn't working PowerShell Universal Issue relates to PowerShell Universal. labels Jan 24, 2023
@adamdriscoll
Copy link
Member

I'm actually seeing this sometimes as well. For example: I install a license.ps1 file and the license it not picked up.

@Omzig Omzig changed the title file change on HD does now show up in admin site file change on HD does not show up in admin site Jan 26, 2023
@Omzig
Copy link
Collaborator Author

Omzig commented Jan 26, 2023

I'm actually seeing this sometimes as well. For example: I install a license.ps1 file and the license it not picked up.

Sometimes my format is super bad, so i will open it up on the HD in vscode and do a format document to get the lines to look nice, and then i have to restart the app pool to get it to show up in the website

@Omzig
Copy link
Collaborator Author

Omzig commented Jan 26, 2023

this will keep me off the HD: https://docs.powershelluniversal.com/development/editor#formatting

@Omzig
Copy link
Collaborator Author

Omzig commented Feb 17, 2023

I had to revert a file change and then i had to recycle the app pool to see my change undo

@Omzig Omzig added Quality-of-Life This issue relates to a quality-of-life improvement. P4 - low Bug has minimal impact, general usage not affected. labels Apr 14, 2023
@adamdriscoll adamdriscoll added the completed The issue has been completed but is not yet released. label Apr 27, 2023
@adamdriscoll
Copy link
Member

This issue has been mentioned on Ironman Software Forums. There might be relevant details there:

https://forums.ironmansoftware.com/t/dashboard-pages-not-showing-changes-in-ui/9083/2

@Omzig Omzig reopened this May 1, 2023
@Omzig
Copy link
Collaborator Author

Omzig commented May 1, 2023

I just changed 10 files with http:// to https:// in the dashboard on the HD directly on the server using vscode find and replace, the psu does not know that the files changed, i am in edit mode for git

@Omzig Omzig added the Core This requires a change to core functionality of the platform. label May 1, 2023
@adamdriscoll
Copy link
Member

We need to grab some logs from your environment on debug. This find\replace scenario was the exact one I tested when checking on this fix.

@Omzig
Copy link
Collaborator Author

Omzig commented May 1, 2023

  1. Edit something on the HD, boom, it refreshes in the PSU editor.
  2. Edit something in the editor, hit save, the file on the HD gets updated, vscode sees the change.
  3. Edit something in vscode on the HD, save
  4. PSU stops watching the file for changes

Emailing you the logs

@adamdriscoll
Copy link
Member

Interesting. So if you edit it with something besides VS Code it reloads it?

@Omzig
Copy link
Collaborator Author

Omzig commented May 1, 2023

Interesting. So if you edit it with something besides VS Code it reloads it?

if you edit something on the HD with notepad, then it reloads... then, go into the PSU editor, and edit the same file, then edit the file on the HD, psu will stop watching the files to reload

if you want a quick call and watch me, you can send me an invite ;)

@Omzig
Copy link
Collaborator Author

Omzig commented May 1, 2023

vscode = a text editor on the server

@adamdriscoll
Copy link
Member

Retry has been implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working completed The issue has been completed but is not yet released. Core This requires a change to core functionality of the platform. P4 - low Bug has minimal impact, general usage not affected. PowerShell Universal Issue relates to PowerShell Universal. Quality-of-Life This issue relates to a quality-of-life improvement.
Projects
None yet
Development

No branches or pull requests

2 participants