Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight URLs #35

Closed
andylima opened this issue Aug 14, 2015 · 6 comments
Closed

Highlight URLs #35

andylima opened this issue Aug 14, 2015 · 6 comments

Comments

@andylima
Copy link

It would be really helpful if URLs were highlighted...

The standard language-hyperlink package already does this for text files, markdown files and comments. For example, by simply adding this to styles.less:

  .markup.underline.link.hyperlink {
    color: #04a6dc;
    text-decoration: underline;
  }

...URLs show up in blue, and underlined. :)

Can we extend this functionality to atom-tasks' .todo / .taskpaper files?

@lnmunhoz
Copy link

Can you create a PR for this solution or explain how you did it? I want this feature too but I tried to change on tasks.less file on the package source and didn't work.

@andylima
Copy link
Author

@lnmunhoz This isn't the full solution — it's a feature request. :)

I still don't know a lot about Atom, but I guess that the standard language-hyperlink package needs to add support for atom-tasks' .todo / .taskpaper files.

I really haven't got the time to pursue this further (for the foreseeable future) — Maybe you can request this at https://github.com/atom/language-hyperlink/issues ?

...Something like: "Add support for URLs in atom-tasks' .todo, .taskpaper files" for the title... You get the picture. ;)

Please let us know how it goes! Thanks!

@lnmunhoz
Copy link

Got it. Thank you!

@irrationalistic
Copy link
Owner

Hey guys! Thanks for exploring this.

Right now, the textual parts of each task are parsed additionally through the standard gfm language. This means that urls in the markdown format will receive proper highlighting. Of course, you are asking for normal urls to also be highlighted even if they are not in the markdown format. This should be doable, but I'll definitely look at the language-hyperlink package to see if there is anything we can borrow!

@andylima
Copy link
Author

I'll definitely look at the language-hyperlink package to see if there is anything we can borrow!

Thanks, @irrationalistic for looking into this! And... ahem... for this whole package! ;)

@irrationalistic
Copy link
Owner

I'm running into a lot of bugs for a few of the other tasks as well. Seems something in a recent update got all confused with my local development of packages. Working through it, so i'll keep you posted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants