build fixes when using install-glib and on openbsd #1181
Merged
+53
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ailin-nemui
added
the
auto-merge
|
these are fixes in an order -only dependency that was missed (had to be manually added now) due to fix #1166 and automatic configuration of some options for building glib on openbsd |
|
@irssi/developers |
dequis
reviewed
Apr 23, 2020
|
I guess it's fine! Why do we even have an install-glib, anyway? |
|
good question, maybe to work around #1180 with -Dinstall-glib=force |
|
IIIiii really don't think we should be in the business of fixing issues with our dependencies that distros don't. |
|
To answer my own question: the oss-fuzz build script downloads and statically links glib https://github.com/google/oss-fuzz/blob/master/projects/irssi/build.sh#L37 |
|
oh, good to know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.