Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/save replaces symlinks with regular files #906

Closed
meribold opened this issue Aug 11, 2018 · 4 comments
Closed

/save replaces symlinks with regular files #906

meribold opened this issue Aug 11, 2018 · 4 comments
Milestone

Comments

@meribold
Copy link
Contributor

@meribold meribold commented Aug 11, 2018

The /save command behaves differently on master (I tested 85df01d) than in 1.1.1: /save now replaces symbolic links in ~/.irssi/ with regular files. The new behavior is annoying for people that keep their dotfiles in a VCS repository and mostly use symlinks in $HOME.

8deb618 may be the commit that changed the behavior.

@meribold
Copy link
Contributor Author

@meribold meribold commented Aug 11, 2018

I confirmed that b2b1ac6 behaves in the same way as 1.1.1 (symlinks are preserved) and that symlinks are replaced in 8deb618 .

@meribold
Copy link
Contributor Author

@meribold meribold commented Aug 11, 2018

What do you think @dequis?

@dequis
Copy link
Member

@dequis dequis commented Aug 11, 2018

Welp

@meribold
Copy link
Contributor Author

@meribold meribold commented Aug 12, 2018

Maybe we can resolve dest_name with realpath(3) before we rename in line 352 of write.c?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants