Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/save replaces symlinks with regular files #906

Closed
meribold opened this issue Aug 11, 2018 · 4 comments · Fixed by #909
Closed

/save replaces symlinks with regular files #906

meribold opened this issue Aug 11, 2018 · 4 comments · Fixed by #909
Labels
bug WIP
Milestone
1.2.0

Comments

@meribold
Copy link
Contributor

The /save command behaves differently on master (I tested 85df01d) than in 1.1.1: /save now replaces symbolic links in ~/.irssi/ with regular files. The new behavior is annoying for people that keep their dotfiles in a VCS repository and mostly use symlinks in $HOME.

8deb618 may be the commit that changed the behavior.
@meribold
Copy link
Contributor Author

I confirmed that b2b1ac6 behaves in the same way as 1.1.1 (symlinks are preserved) and that symlinks are replaced in 8deb618 .

@meribold
Copy link
Contributor Author

What do you think @dequis?

@dequis
Copy link
Member

dequis commented Aug 11, 2018

Welp

@meribold
Copy link
Contributor Author

Maybe we can resolve dest_name with realpath(3) before we rename in line 352 of write.c?

@meribold meribold mentioned this issue Aug 12, 2018
Merged
@ailin-nemui ailin-nemui added this to the 1.2.0 milestone Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug WIP
Projects
None yet
Milestone
1.2.0
Development

Successfully merging a pull request may close this issue.

Fix /save replacing symlinks with regular files meribold/irssi
3 participants
@dequis @meribold @ailin-nemui