Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please make additional data on Limits available #22

Closed
duanemay opened this issue Oct 26, 2017 · 4 comments
Closed

Please make additional data on Limits available #22

duanemay opened this issue Oct 26, 2017 · 4 comments

Comments

@duanemay
Copy link

The GET /payment-methods call is returning additional data that is not captured in the Limit object

For Example:
"limits": {
"type": "fiat_account",
"name": "Coinbase Account",
"sell": [

"limits": {
"type": "bank",
"name": "Bank Account",
"buy": [

I created a fix for this in PR #20 commit 1da2556

@robevansuk
Copy link
Collaborator

robevansuk commented Jan 22, 2018

feel free to add missing data fields and make a pull request - this is not something I've wanted/needed in the past so it probably got missed out. Otherwise I'll stick it on the list of things to look at (later)!

@duanemay
Copy link
Author

They are already in PR #20 commit 1da2556.
I think it was closed without merge

@robevansuk
Copy link
Collaborator

+1

@irufus
Copy link
Owner

irufus commented Feb 8, 2018

type and limit are already captured in the PaymentType.
When testing the additional fields against the sandbox no data was returned under Limit.

I was able to confirm all of this using the PaymentTests::hasAvailablePayments() test.

@irufus irufus closed this as completed Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants