Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to constructor based Injection for all services #38

Closed
irufus opened this issue Feb 1, 2018 · 7 comments
Closed

Update to constructor based Injection for all services #38

irufus opened this issue Feb 1, 2018 · 7 comments

Comments

@irufus
Copy link
Owner

irufus commented Feb 1, 2018

https://stackoverflow.com/questions/21218868/explain-why-constructor-inject-is-better-than-other-options

`
//current injection (i.e. Withdrawals Service)
@Autowired
GdaxExchange gdaxExchange;

//Constructor injection method
GdaxExchange gdaxExchange;
@Inject
public WithdrawalService (GdaxExchange gdaxExchange){ ... }
`

@irufus irufus added this to To Do in Version 1.1 via automation Feb 1, 2018
@robevansuk
Copy link
Collaborator

robevansuk commented Feb 5, 2018

thought Id used constructor injection when I'd put the dependency in. Clearly not. oops. will update in the next couple of weeks. got a scala project to finish first.

@irufus
Copy link
Owner Author

irufus commented Feb 5, 2018

No rush. I'm clearing up the issues one by one so we can look at this in the future.

@robevansuk
Copy link
Collaborator

I've made amendments over at my own repo which hopefully can be merged in when the orderbook is sorted. Just need to make things a bit more configurable first of all.

@gvespucci
Copy link

Hi, is still issue a thing? I'm not able to find an @Autowired - for example - in the repo. Thanks

@robevansuk
Copy link
Collaborator

Its fixed on a branch https://github.com/irufus/gdax-java/pull/62/files

@robevansuk
Copy link
Collaborator

I'm going to remove the gui and start over - it was nice when it worked but it wasn't very good and I'd like to try building it again in JavaFx

@robevansuk
Copy link
Collaborator

robevansuk commented Jul 27, 2020

This is now done / the spring application removed from the codebase as the gui was not really a part of the library and should ideally be separated out from this codebase.

Version 1.1 automation moved this from To Do to Done Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Version 1.1
  
Done
Development

No branches or pull requests

3 participants