-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to constructor based Injection for all services #38
Comments
thought Id used constructor injection when I'd put the dependency in. Clearly not. oops. will update in the next couple of weeks. got a scala project to finish first. |
No rush. I'm clearing up the issues one by one so we can look at this in the future. |
I've made amendments over at my own repo which hopefully can be merged in when the orderbook is sorted. Just need to make things a bit more configurable first of all. |
Hi, is still issue a thing? I'm not able to find an |
Its fixed on a branch https://github.com/irufus/gdax-java/pull/62/files |
I'm going to remove the gui and start over - it was nice when it worked but it wasn't very good and I'd like to try building it again in JavaFx |
This is now done / the spring application removed from the codebase as the gui was not really a part of the library and should ideally be separated out from this codebase. |
https://stackoverflow.com/questions/21218868/explain-why-constructor-inject-is-better-than-other-options
`
//current injection (i.e. Withdrawals Service)
@Autowired
GdaxExchange gdaxExchange;
//Constructor injection method
GdaxExchange gdaxExchange;
@Inject
public WithdrawalService (GdaxExchange gdaxExchange){ ... }
`
The text was updated successfully, but these errors were encountered: