Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint #123

Closed
zayKenyon opened this issue Aug 27, 2022 · 3 comments
Closed

Lint #123

zayKenyon opened this issue Aug 27, 2022 · 3 comments
Labels
help wanted Extra attention is needed style Changes that do not affect the meaning of the code: white-space, formatting, missing semi-colons etc

Comments

@zayKenyon
Copy link
Owner

zayKenyon commented Aug 27, 2022

Judging by our 3 different file naming conventions and countless more variable naming conventions, I think it's time to standardise.

After doing some research, I think we should go with pycodestyle; it uses the PEP 8 convention, which we started using with #115.

@zayKenyon zayKenyon added style Changes that do not affect the meaning of the code: white-space, formatting, missing semi-colons etc help wanted Extra attention is needed labels Aug 27, 2022
@zayKenyon
Copy link
Owner Author

After some consideration, we will go with pylint due to it's ability to integrate with IDEs and code editors.

@zayKenyon zayKenyon linked a pull request Aug 28, 2022 that will close this issue
23 tasks
@ThisIsTeddyBear
Copy link

I did not understand the complete issue but I think, I can help can someone link or please refer to what all are the pending items in this issue.
And finally what is the coding standard decided and finally being used.

@zayKenyon
Copy link
Owner Author

I did not understand the complete issue but I think, I can help can someone link or please refer to what all are the pending items in this issue. And finally what is the coding standard decided and finally being used.

There is an old list of files in #124 . This PR is mainly about addressing the numerous different code styles we have running throughout the project, and also removing redudant code (mainly code that's commented out). As for code style, I plan to follow most of PEP8, but I don't have a list of what I'm deeming unreasonable.

You can make a new PR superseeding #124 , but if you're looking for more immediate merges than I'd recommend working on issues with the 'bug' flair too.

@zayKenyon zayKenyon closed this as not planned Won't fix, can't repro, duplicate, stale Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed style Changes that do not affect the meaning of the code: white-space, formatting, missing semi-colons etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants