Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh the table on enter key #5

Closed
wants to merge 1 commit into from
Closed

Refresh the table on enter key #5

wants to merge 1 commit into from

Conversation

Ashesh3
Copy link
Contributor

@Ashesh3 Ashesh3 commented Aug 18, 2021

Instead of exiting the program and having the user to run it again every time, It's better to keep the window open and just wait for an enter key to update the table, this seems more convenient.
Note: the presence function is renamed to get_presence so that it does not collide with the local variable's name (Python complains about this)

Instead of exiting the program and having the user to run it again every time, It's better to keep the window open and just wait for an enter key to update the table, this seems more convenient.
Note: the `presence` function is renamed to `get_presence` so that it does not collide with the local variable's name (Python complains about this)
@OwOHamper
Copy link
Collaborator

I'll rename the variable but on the key is bad idea because it adds keyboard input delay.

@Ashesh3
Copy link
Contributor Author

Ashesh3 commented Aug 18, 2021

I'll rename the variable but on the key is bad idea because it adds keyboard input delay.

Sorry, i didn't really get what you mean by keyword input delay here. The table is initially displayed once and then it just stays there until the user presses enter key, then it just refreshes itself.

There is no delay initially, the table is shows as soon as the program is started. Just it refreshes the info when enter key is pressed instead of the user having to "press any key to exit the program" then re-launching the program again.

@OwOHamper
Copy link
Collaborator

hmmmm I thought you would like press keybind in-game and it would refresh. Alright I'll commit in few hours

@Ashesh3
Copy link
Contributor Author

Ashesh3 commented Aug 18, 2021

hmmmm I thought you would like press keybind in-game and it would refresh. Alright I'll commit in few hours

Thanks! sounds good.

Also in-game keybind sounds like a good separate future, but I doubt it would help much though because most users would need to alt-tab out of the game to access this table anyways, so just hitting enter key inside the console window of this app sounds like a simpler and more user friendly option.

@OwOHamper
Copy link
Collaborator

ye but thing about in-game keybinds is that they add a lot of input delay

@OwOHamper
Copy link
Collaborator

Alright added the feature tutorial video coming soon

@OwOHamper OwOHamper closed this Aug 18, 2021
@Ashesh3 Ashesh3 deleted the patch-1 branch August 18, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants