-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fake 5 runner not finding script if it is not in root folder #21
Comments
Thanks for reporting. Can you try using the advanced options and setting the full command line? |
Also can you attach the complete verbose (Setting "System.Debug" to true) output? It will help me fix this without the need to reproduce myself ... |
Ok, so I tried different variations: Normal step with reference to Verbose Log
|
Running full command line ( Verbose Log
|
Lastly, I tried a combination of the two, normal task with script path set to Verbose Log
|
@severisv While testing I think there are some edge cases when specifying working dir and relative paths. Would you expect the relative path to be relative to the working directory, relative to the project root or maybe both if only one exists? |
I'm a bit conflicted, because when I first set it up, I just specified I think the problem for me was that the working directory option was "hidden" under "Complete Command Line", so the whole working directory logic didn't really cross my mind. Also, when I first tried it, I actually thought the working directory setting only applied to the "Set the complete fake command line" way of running the script. For me, moving the Working Directory-option up with the other main inputs would probably make it easier to understand. To answer your question I think
|
Actually this was the "intended" behavior, but as it is not working anyway we can change that in any aspect
Yes I guess that is was the user assumes, however it is not easy to implement as VSTS is resolving the paths from the file picker already, so we never see the relative path. We could change to a regular text input, but then users can no longer just select the build script. I'd assume the most "standard" use case is to add the task and select a build script.
|
This makes sense to me aswell, I do see the point of users selecting the file with |
@severisv Please try again with |
Running - task: isaacabraham.fsharp-helpers-extension.a2dadf20-1a83-4220-a4ee-b52f6c77f3cf.FAKE5@1
displayName: "Run FAKE script"
inputs:
FakeVersion: 5.6.1
FakeScript: scripts/build.fsx
WorkingDirectory: scripts now works as expected. Thanks for the great work! |
Yes the following is now tested before publishing to the marketplace: https://dev.azure.com/fakebuild/FSProjects/_git/Test_Extensions?path=%2F.azure-pipelines.yml&version=GBmaster |
Agent: Hosted Linux Preview
Task:
Error:
The text was updated successfully, but these errors were encountered: