Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

latest release, context menu does not close on selection #11

Closed
born2net opened this issue Apr 11, 2017 · 9 comments
Closed

latest release, context menu does not close on selection #11

born2net opened this issue Apr 11, 2017 · 9 comments

Comments

@born2net
Copy link

born2net commented Apr 11, 2017

latest release, context menu does not close on selection

no_close

let me know if you need more info

config:

  <div (click)="$event.preventDefault()">
            <small class="debug">{{me}}</small>
            <h4 style="color: #a9a9a9">total timelines: {{m_campaignTimelinesModels?.size}}</h4>

            <hr class="dottedHR">
            <div id="dragcontainer">
                <screen-template #st class="draggableTimeline"
                                 *ngFor="let screenTemplate of m_screenTemplates$ | async; trackBy: trackByFn"
                                 (contextmenu)="onContextMenu($event, screenTemplate)"
                                 (click)="_onScreenTemplateSelected(screenTemplate, st)"
                                 (onDivisionDoubleClicked)="_onDivisionDoubleClicked($event)"
                                 [setTemplate]="screenTemplate">
                </screen-template>
            </div>
            <context-menu>
                <ng-template contextMenuItem let-item (execute)="_onContextClicked('load props ',$event.item)">
                    timeline properties for {{item?.name}}
                </ng-template>
                <ng-template contextMenuItem divider="true"></ng-template>
                <ng-template contextMenuItem (execute)="_onContextClicked('edit',$event.item)"><span i18n>edit layout</span></ng-template>
                <ng-template contextMenuItem (execute)="_onContextClicked('nextch',$event.item)"><span i18n>next channel</span></ng-template>
            </context-menu>
        </div>

regards

Sean

@isaacplmann
Copy link
Owner

What's the <context-menu></context-menu> line for? Still trying to reproduce your issue.

@born2net
Copy link
Author

yes no need for that, removed it, but same issue :(

@born2net
Copy link
Author

by the way, it DOES close on the first time the context is used, but on 2nd time, it does not.

@isaacplmann
Copy link
Owner

Just reproduced it - now I need to figure out why it happens. Thanks for reporting this.

@born2net
Copy link
Author

thank you!!!!!

@isaacplmann
Copy link
Owner

I think it might be related to using the context menu in a lazy loaded module - are you doing that? I'm testing a fix now.

@isaacplmann
Copy link
Owner

Try with version 1.0.3.

@born2net
Copy link
Author

ok

@born2net
Copy link
Author

yes I am using lazy load, and 1.3 looks great,
TX again,
Sean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants