Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 10 support #215

Closed
fergardi opened this issue Jun 25, 2020 · 11 comments
Closed

Angular 10 support #215

fergardi opened this issue Jun 25, 2020 · 11 comments

Comments

@fergardi
Copy link

Hello!

I was trying to update from Angular9 to Angular10 and got this error:

Using package manager: 'npm'
Collecting installed dependencies...
Found 57 dependencies.
Fetching dependency metadata from registry...
                  Package "ngx-tour-core" has an incompatible peer dependency to "@angular/core" (requires ">=7.0.0 <9.0.0" (extended), would install "10.0.0").
                  Package "ngx-tour-core" has an incompatible peer dependency to "@angular/common" (requires ">=7.0.0 <9.0.0" (extended), would install "10.0.0").
                  Package "ngx-tour-md-menu" has an incompatible peer dependency to "@angular/animations" (requires ">=7.0.0 <9.0.0" (extended), would install "10.0.0").
                  Package "ngx-tour-core" has an incompatible peer dependency to "@angular/router" (requires ">=7.0.0 <9.0.0" (extended), would install "10.0.0").
× Migration failed: Incompatible peer dependencies found.
Peer dependency warnings when installing dependencies means that those dependencies might not work correctly together.
You can use the '--force' option to ignore incompatible peer dependencies and instead address these warnings later.

Any plans to upgrade to Angular10?

@soarfalc
Copy link

I join the request

@fergardi
Copy link
Author

Any news? Is this repository still maintained?

@fergardi
Copy link
Author

fergardi commented Aug 7, 2020

Due to the lack of responses I finally managed to "solve" this issue with the --force flag. Everything is working as expected.

@hakimio
Copy link
Collaborator

hakimio commented Aug 10, 2020

@fergardi you should leave this open until Angular 10 support is officially added to the project.

@fergardi fergardi reopened this Sep 4, 2020
@IgnacioHR
Copy link

+1

@abdulbadisabir
Copy link

+1

1 similar comment
@spike008t
Copy link

+1

@spike008t
Copy link

@isaacplmann any idea when 4.2.0 will be published?

@fergardi
Copy link
Author

We are on Angular11 already, and no news...

@alvaro-octal
Copy link

alvaro-octal commented Dec 24, 2020

I forked this library and re-published under another name weeks ago, I've not completed the automation of publishing (in order to avoid this scenarios) but for anyone interested you can use @ngx-tour/core

https://www.npmjs.com/search?q=%40ngx-tour

Maybe this weekend I can try to migrate to Angular 11

@hakimio hakimio closed this as completed Mar 31, 2021
@hakimio
Copy link
Collaborator

hakimio commented Apr 6, 2021

I have created a fork and I have published a new version under a new name: ngx-ui-tour. It's compatible with Angular 11. Test it out and let me know if it works as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants