Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom API setting screen reverts changes before they can be saved #588

Closed
CamSoper opened this issue Feb 14, 2022 · 10 comments
Closed

Custom API setting screen reverts changes before they can be saved #588

CamSoper opened this issue Feb 14, 2022 · 10 comments

Comments

@CamSoper
Copy link

Custom API setting screen reverts changes before they can be saved. I was able to set my custom API URLs by editing the settings.json file directly.

Repro:

  1. Go to Custom API settings screen
  2. Attempt to enter a URL and save
  3. Note the UI reverts changes before they can be saved. I suspect it's some kind of Blazor update thing.

bad-custom-ui

@isaacrlevin
Copy link
Owner

Does the currently nightly version have this issue?

https://presencelight.blob.core.windows.net/nightly/index.html

@CamSoper
Copy link
Author

I'll check tomorrow.

@joeljeffery
Copy link

Confirmed with both store build and nightly build :)

@CamSoper
Copy link
Author

Yep, confirmed for both.

@isaacrlevin
Copy link
Owner

So it works or does not work? :)

@joeljeffery
Copy link

joeljeffery commented Feb 15, 2022

I confirm the same behaviour as reported by @CamSoper in the ticket in both versions. 🙂

Platform: Windows 11

@isaacrlevin
Copy link
Owner

Just updated Nightly, test that please

@CamSoper @joeljeffery

@joeljeffery
Copy link

Works for me! 🙂 Thank you for your prompt fix. And thanks to @CamSoper for opening the issue.

@isaacrlevin - excellent app. Will be telling every smart home geek I know that uses Teams.

@isaacrlevin
Copy link
Owner

Waiting on @CamSoper

@CamSoper
Copy link
Author

CamSoper commented Feb 15, 2022

Looks good to me too, @isaacrlevin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants