Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom API - REST API Body Support #848

Closed
stefanstranger opened this issue Jan 17, 2024 · 5 comments
Closed

Custom API - REST API Body Support #848

stefanstranger opened this issue Jan 17, 2024 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@stefanstranger
Copy link
Contributor

stefanstranger commented Jan 17, 2024 •
edited
Loading

Thanks for creating presenselight.

I want to use the Custom API functionality to send Teams presence information to my Ulanzi Pixel Clock flashed with Awtrix.

The REST API of the Awtrix expects a REST API body to be send for notifications.

Is there an option to include a REST API body message for the Custom API REST methods in PresenceLight?

Regards,
Stefan
@isaacrlevin
Copy link
Owner

Currently the CustomApi mechanism only has support for querystring parameters. I am more than happy to review a PR to add a REST body to that functionality.

@isaacrlevin isaacrlevin added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jan 18, 2024
@stefanstranger
Copy link
Contributor Author

stefanstranger commented Jan 18, 2024 •
edited
Loading

Hi Isaac,

I'm not a developer but when I've time I can try to have a go. I already forked the repo. So that part is already done ;-)

Can you provide some more guidance on how to get started when I want to contribute? Like what are the pre-requisites etc to get the existing version working in Visual Studio?

/Stefan

@stefanstranger
Copy link
Contributor Author

stefanstranger commented Jan 20, 2024 •
edited
Loading

Got it working! Will do some more tests before submitting the PR.

presencelightrestapibody

@isaacrlevin
Copy link
Owner

Functionality added in #850. Will close when Release published

@isaacrlevin
Copy link
Owner

Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stefanstranger @isaacrlevin