In Windows, patterns ending in / match files, too

[cowboy]

I'm seeing this bug in v3.1.14. Given this directory structure:

deep
├── deep.txt
└── deeper
    ├── deeper.txt
    └── deepest
        └── deepest.txt

In OS X I get this (which is expected)

$ node -pe "require('glob').sync('d**/**')"
[ 'deep',
  'deep/deep.txt',
  'deep/deeper',
  'deep/deeper/deeper.txt',
  'deep/deeper/deepest',
  'deep/deeper/deepest/deepest.txt' ]

$ node -pe "require('glob').sync('d**/**/')"
[ 'deep/', 'deep/deeper/', 'deep/deeper/deepest/' ]

But in Windows I get this (this is not expected)

C:\test>node -pe "require('glob').sync('d**/**')"
[ 'deep',
  'deep/deep.txt',
  'deep/deeper',
  'deep/deeper/deeper.txt',
  'deep/deeper/deepest',
  'deep/deeper/deepest/deepest.txt' ]

C:\test>node -pe "require('glob').sync('d**/**/')"
[ 'deep/',
  'deep/deep.txt/',
  'deep/deeper/',
  'deep/deeper/deeper.txt/',
  'deep/deeper/deepest/',
  'deep/deeper/deepest/deepest.txt/' ]

[isaacs]

Interesting. So the directory filtering is failing.

[cowboy]

In case this helps in any way, when I use the mark option, matched directories have trailing slashes, although the files list still contains non-directories when it shouldn't

OS X (this works as-expected):

$ node -pe "require('glob').sync('d**/**', {mark: true})"
[ 'deep/',
  'deep/deep.txt',
  'deep/deeper/',
  'deep/deeper/deeper.txt',
  'deep/deeper/deepest/',
  'deep/deeper/deepest/deepest.txt' ]

$ node -pe "require('glob').sync('d**/**/', {mark: true})"
[ 'deep/', 'deep/deeper/', 'deep/deeper/deepest/' ]

Windows (the trailing mark slashes are correct, but non-directories should be removed from the result set in the 2nd example):

C:\test>node -pe "require('glob').sync('d**/**', {mark: true})"
[ 'deep/',
  'deep/deep.txt',
  'deep/deeper/',
  'deep/deeper/deeper.txt',
  'deep/deeper/deepest/',
  'deep/deeper/deepest/deepest.txt' ]

C:\test>node -pe "require('glob').sync('d**/**/', {mark: true})"
[ 'deep/',
  'deep/deep.txt',
  'deep/deeper/',
  'deep/deeper/deeper.txt',
  'deep/deeper/deepest/',
  'deep/deeper/deepest/deepest.txt' ]

[isaacs]

Yeah, definitely a bug. Patch welcome.

[dignifiedquire]

I'll have a look at it tomorrow.

[dignifiedquire]

Well I actually did that, but I never got around to fix anything. The first big problem is that basically nothing of the test suite is working on windows.

1. Fails to find .js files when given a directory on Windows tapjs/tapjs#57 results that one needs to specify every single file in the test cmd if you want to run it.
2. All the bash tests don't work because, well there is no bash on Windows.

Aside from that I did some digging into the code to find out what was going wrong but I couldn't really figure out what was happening without a unix machine to compare. As soon as I get my Windows VM up and running I'll take another look.