Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.7.0 should not be compatible 2.2.8 #198

Closed
balihoo-cnorwood opened this issue Aug 14, 2019 · 6 comments
Closed

Version 2.7.0 should not be compatible 2.2.8 #198

balihoo-cnorwood opened this issue Aug 14, 2019 · 6 comments

Comments

@balihoo-cnorwood
Copy link

We have an old system that builds using node 4. It uses del ver 1.2.1, which has in its dependencies
"rimraf": "^2.2.8"

Yesterday it built fine, today it broke because it pulled 2.7.0, which was released in the last 24 hrs.

@favna
Copy link

favna commented Aug 15, 2019

Wouldn't it be more prudent to move towards ditching Node 4 and upgrading? I mean not saying that this issue is a non-issue, but Node 4 is waaay EOL. Currently Node 10 is LTS (8 being Maintenance LTS until December when it EOL's) and Node 6 went EOL earlier this year. See Node releases here

@balihoo-cnorwood
Copy link
Author

100% agree that it would be more prudent, I'm very familiar with node releases, and you can ignore the issue if you like, i'm sure very few are affected.

At this point you probably don't want to roll back your code changes that require node 6 or greater, perhaps next time follow engines guidelines from https://docs.npmjs.com/files/package.json#engines

You can specify the version of node that your stuff works on:

{ "engines" : { "node" : ">=0.10.3 <0.12" } }

And, like with dependencies, if you don’t specify the version (or if you specify “*” as the version), then any version of node will do.

@balihoo-cnorwood
Copy link
Author

FYI - commit requiring node 6 was first part of 2.6.3, here's comment with more details.
dc1682d#r34690842

@bcoe
Copy link
Contributor

bcoe commented Aug 15, 2019

@isaacs any reason not to bump to 3.x and publish 2.x with a var instead of let?

Personally, while I think EOL versions of Node.js should be avoided, seems like this should be a major bump.

@bcoe
Copy link
Contributor

bcoe commented Aug 15, 2019

I see this was already done, folks on Node 4 should switch to 2.7.1:

012ecbb

@isaacs isaacs closed this as completed Aug 15, 2019
@balihoo-cnorwood
Copy link
Author

Thanks for the quick fix!! I now see this a duplicate of #194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants