Skip to content

Latest commit

 

History

History
51 lines (38 loc) · 1.83 KB

CONTRIBUTING.md

File metadata and controls

51 lines (38 loc) · 1.83 KB
Raw

Contributing to node-middleware

So you want to contribute to node-middleware? Fantastic! Here's a brief overview on how best to do so.

What to change

Here's some examples of things you might want to make a pull request for:

  • New features
  • Bugfixes
  • Inefficient blocks of code

If you have a more deeply-rooted problem with how the program is built or some of the stylistic decisions made in the code, it's best to create an issue before putting the effort into a pull request. The same goes for new features - it is best to check the project's direction, existing pull requests, and currently open and closed issues first.

Style

  • Two spaces, not tabs
  • Semicolons are not optional
  • All pages should render on the server and the client. The site should be usable without javascript.
  • Review our style guide for more information.

Look at existing code to get a good feel for the patterns we use. Please run tests before submitting any pull requests. Instructions for running tests can be found in the README.

Using Git appropriately

  1. Fork the repository to your Github account.
  2. Create a topical branch - a branch whose name is succint but explains what you're doing, such as "change-orangered-to-periwinkle"
  3. Make your changes, committing at logical breaks.
  4. Push your branch to your personal account
  5. Create a pull request
  6. Watch for comments or acceptance

Please make separate branches for unrelated changes!

Licensing

node-middleware is MIT licensed. See details in the LICENSE file. This is a very permissive scheme, GPL-compatible but without many of the restrictions of GPL.