Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to support Firebase 3.x and Angularfire 2.x #7

Open
petrusek opened this issue Aug 17, 2016 · 3 comments
Open

Update to support Firebase 3.x and Angularfire 2.x #7

petrusek opened this issue Aug 17, 2016 · 3 comments

Comments

@petrusek
Copy link
Contributor

There is a new version of Firebase and Angularfire, which are not compatible with the old extern files. It would be great to update them, so also the projects depending on these externs could migrate easily.

Note: If it is easier for you to write some notes on how to re-create these externs (what tools to use and how - hope it is not just manual work), I could help.

@petrusek
Copy link
Contributor Author

petrusek commented Aug 19, 2016

Actually I found out, that

  1. externs for Firebase 3.x are provided by the Firebase team in their npm package. Unfortunately, they are not in the bower package (yet).
  2. externs for Angularfire 2.x are not needed, as the original source (within the bower package) comes with annotations, so it can be compiled together with my app. WRONG

@petrusek
Copy link
Contributor Author

I was wrong in 2., about AngularFire, it is written in an IIFE and does not export any types/symbols for Closure Compiler, so it can't be compiled together with my app. Or at least I don't know how.

@adelespinasse
Copy link

More specifically, externs for the current version of Firebase are here: https://github.com/firebase/firebase-js-sdk/tree/master/packages/firebase/externs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants